Pass explicit font paths to fontspec in backend_pgf. #10339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks a lot for the work. This time it worked like a charm. I tried different parameters and the code worked every time. I'm looking forward to see your improvements merged upstream. If you need further testing on macOS, please let me know. |
jklymak
approved these changes
Jan 29, 2018
9b8d6f1 to
a0313ec
Compare
4dc3ed1 to
b002924
Compare
timhoffm
reviewed
May 6, 2018
| # backslashes. 2) The dirname needs to include a separator. | ||
| dirname = Path(fm.findfont(family)).parent.as_posix() + "/" | ||
| latex_fontspec.append( | ||
| r"\%s{%s}[Path=%s]" % (command, basename, dirname)) |
There was a problem hiding this comment.
basename seems undefined. Apparently an untested code path 😦
| @@ -77,23 +58,20 @@ def _parse_lualatex_version(output): | |||
| def get_fontspec(): | |||
| """Build fontspec preamble from rc.""" | |||
| latex_fontspec = [] | |||
| texcommand = get_texcommand() | |||
| texcommand = rcParams["pgf.texsystem"] | |||
There was a problem hiding this comment.
Do we explicitly not want the check and fallback mechanism to xelatex, which was implemented in get_texcommand?
There was a problem hiding this comment.
That does already get checked during standard rcparam validation.
timhoffm
approved these changes
May 6, 2018
|
I'll skip the bonus points. |
6 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
xref #10307. @laborleben Can you check whether this works for you? Seems better than continuously posting patches :)
Basically
PR Checklist