Skip to content

DOC: clarify that clim is not a valid kwarg if vmin/vmax are used #10354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2018

Conversation

jklymak
Copy link
Member

@jklymak jklymak commented Jan 31, 2018

PR Summary

Closes #10346

@heath730 noted that clim is listed as a QuadMesh kwarg, but calling in pcolormesh is ignored in favour of vmin/vmax. This just edits the ScalarMappable.set_clim() docstring, which is mapped downstream to methods that call ScalarMappable to make this clear.

As discussed in #10346, its a bit strange to pass all the set_blah strings downstream; some of them make no sense, and some have no effect. This is probably a bigger issue that will need some thought (after traitlets??)

@jklymak jklymak added this to the v2.2 milestone Jan 31, 2018
@jklymak
Copy link
Member Author

jklymak commented Jan 31, 2018

Now reads:

matplotlib_axes_axes_pcolormesh_ _matplotlib_2_1_1_post1228_ge5b3ea6_documentation

Copy link
Member

@efiring efiring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an improvement.

@dstansby dstansby merged commit aa49b0a into matplotlib:master Jan 31, 2018
@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passing clim as keyword argument to pcolormesh does not change limits.
4 participants