Fix deprecations in examples #10385
Merged
Fix deprecations in examples #10385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The normal colorbar works fine if calling colorbar.set_ticks instead of colobar.ax.set_ticks, which is noted in the deprecation warning. There is no real benefit of showing the axes_grid1 version now.
Unfortunately, csv2rec provides some automatic converters, so it can't be replaced entirely with np.genfromtxt or np.loadtxt.
|
There are also a few warnings about |
62a7788 to
c4197df
Compare
timhoffm
reviewed
Feb 6, 2018
| datafile = cbook.get_sample_data('msft.csv', asfileobj=False) | ||
| print('loading %s' % datafile) | ||
| r = csv2rec(datafile)[-40:] | ||
| r = np.genfromtxt(datafile, delimiter=',', names=True, |
There was a problem hiding this comment.
Maybe use a more telling name like msft_data instead of r?
|
Oh, hmmm, that should give a warning, but for constrained layout, not tight layout! Ooops.. |
|
@jklymak Actually, I was referring to the examples, not the tests. For example, |
c4197df to
5193922
Compare
|
The last one is mine, and on purpose to show the failure in the tutorial. The |
dstansby
approved these changes
Feb 9, 2018
| @@ -2411,8 +2411,11 @@ def plotfile(fname, cols=(0,), plotfuncs=None, | |||
|
|
|||
| if plotfuncs is None: | |||
| plotfuncs = dict() | |||
| r = mlab.csv2rec(fname, comments=comments, skiprows=skiprows, | |||
| checkrows=checkrows, delimiter=delimiter, names=names) | |||
| from matplotlib.cbook import mplDeprecation | |||
There was a problem hiding this comment.
Should this whole method be deprecated since it depends on csv2rec?
There was a problem hiding this comment.
Yes, and point people at pandas.
There was a problem hiding this comment.
You want to deprecate plt.plotfile for Pandas? Probably should be an independent PR.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This fixes several deprecation warnings that are triggered by the examples.
Currently,
plt.plotfilecallsmlab.csv2rev, which is deprecated. Because that function provides some automatic converters, I could not replace it withnp.genfromtxtornp.loadtxtright away, as that would be a behaviour change. Even the examples take advantage of this behaviour.plt.plotfilealso triggers a warning about re-using anAxesspec. I have not looked too deeply into fixing that one.PR Checklist