Skip to content

OOification of the new examples from #10306 #10393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2018

Conversation

afvincent
Copy link
Contributor

PR Summary

This PR simply tries to make the examples added in #10306 a bit more consistent with the current trend of promoting the object-oriented API rather than the Pyplot one. I was planning to suggest the small changes in the original thread but the latter got merged while I was writing my post 🐑...

Being there, this PR also slightly increase the title padding in title_xlabel_top.py, to make room for the tick labels and prevent a not very nice-looking overlap. Please note that this change could (should) be removed if in the future a feature like #9498 was going to be introduced in Matplotlib.

Some questions that may still be open:

  • Should we merge the one examples into a single one? (I do not remember where we are about having very short and simple examples vs more complex/comprehensive ones)
  • If we prefer keeping two different files, should we make the names a bit more consistent? (e.g. tick_label_right.py <- tick_ylabel_right.py)

PR Checklist

  • Code is PEP 8 compliant: hopefully
  • Documentation is sphinx and numpydoc compliant: CI will judge

@tacaswell tacaswell added this to the v2.2 milestone Feb 8, 2018
@tacaswell
Copy link
Member

Just waiting for CI to spin on the docs.

@QuLogic QuLogic merged commit 84008ea into matplotlib:master Feb 8, 2018
@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants