-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Deprecate LocatableAxes from toolkits #10403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
eee9112
Remove old ChangeLog from axes_grid.
QuLogic ff6139c
Remove cross-references to axes_grid.
QuLogic 15d9b8e
Deprecate LocatableAxesBase and make it a no-op.
QuLogic 947ebe9
Deprecate locatable_axes_factory and make it a no-op.
QuLogic e041adc
Deprecate any LocatableAxes in toolkits.
QuLogic 7421b0e
DOC: Add deprecation changelog for LocatableAxes stuff.
QuLogic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
Deprecation of ``LocatableAxes`` in toolkits | ||
-------------------------------------------- | ||
|
||
The ``LocatableAxes`` classes in toolkits have been deprecated. The base `Axes` | ||
classes provide the same functionality to all subclasses, thus these mixins are | ||
no longer necessary. Related functions have also been deprecated. Specifically: | ||
|
||
* ``mpl_toolkits.axes_grid1.axes_divider.LocatableAxesBase``: no specific | ||
replacement; use any other ``Axes``-derived class directly instead. | ||
* ``mpl_toolkits.axes_grid1.axes_divider.locatable_axes_factory``: no specific | ||
replacement; use any other ``Axes``-derived class directly instead. | ||
* ``mpl_toolkits.axes_grid1.axes_divider.Axes``: use | ||
`mpl_toolkits.axes_grid1.mpl_axes.Axes` directly. | ||
* ``mpl_toolkits.axes_grid1.axes_divider.LocatableAxes``: use | ||
`mpl_toolkits.axes_grid1.mpl_axes.Axes` directly. | ||
* ``mpl_toolkits.axisartist.axes_divider.Axes``: use | ||
`mpl_toolkits.axisartist.axislines.Axes` directly. | ||
* ``mpl_toolkits.axisartist.axes_divider.LocatableAxes``: use | ||
`mpl_toolkits.axisartist.axislines.Axes` directly. |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
from mpl_toolkits.axes_grid1.axes_divider import Divider, AxesLocator, SubplotDivider, \ | ||
AxesDivider, locatable_axes_factory, make_axes_locatable | ||
|
||
from mpl_toolkits.axes_grid.axislines import Axes | ||
LocatableAxes = locatable_axes_factory(Axes) | ||
from mpl_toolkits.axes_grid1.axes_divider import ( | ||
AxesDivider, AxesLocator, Divider, SubplotDivider, locatable_axes_factory, | ||
make_axes_locatable) | ||
from mpl_toolkits.axisartist.axes_divider import LocatableAxes | ||
from mpl_toolkits.axisartist.axislines import Axes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,26 +1,3 @@ | ||
import mpl_toolkits.axes_grid1.axes_grid as axes_grid_orig | ||
from .axes_divider import LocatableAxes | ||
|
||
|
||
class CbarAxes(axes_grid_orig.CbarAxesBase, LocatableAxes): | ||
def __init__(self, *args, orientation, **kwargs): | ||
self.orientation = orientation | ||
self._default_label_on = False | ||
self.locator = None | ||
super().__init__(*args, **kwargs) | ||
|
||
def cla(self): | ||
super().cla() | ||
self._config_axes() | ||
|
||
|
||
class Grid(axes_grid_orig.Grid): | ||
_defaultLocatableAxesClass = LocatableAxes | ||
|
||
|
||
class ImageGrid(axes_grid_orig.ImageGrid): | ||
_defaultLocatableAxesClass = LocatableAxes | ||
_defaultCbarAxesClass = CbarAxes | ||
|
||
|
||
AxesGrid = ImageGrid | ||
from mpl_toolkits.axisartist.axes_divider import LocatableAxes | ||
from mpl_toolkits.axisartist.axes_grid import ( | ||
AxesGrid, CbarAxes, Grid, ImageGrid) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,19 @@ | ||
from matplotlib import cbook | ||
|
||
from mpl_toolkits.axes_grid1.axes_divider import ( | ||
Divider, AxesLocator, SubplotDivider, AxesDivider, locatable_axes_factory, | ||
make_axes_locatable) | ||
|
||
from mpl_toolkits.axes_grid.axislines import Axes | ||
LocatableAxes = locatable_axes_factory(Axes) | ||
from mpl_toolkits.axisartist.axislines import Axes as _Axes | ||
|
||
|
||
@cbook.deprecated('3.0', | ||
alternative='mpl_toolkits.axisartist.axislines.Axes') | ||
class Axes(_Axes): | ||
pass | ||
|
||
|
||
@cbook.deprecated('3.0', | ||
alternative='mpl_toolkits.axisartist.axislines.Axes') | ||
class LocatableAxes(_Axes): | ||
pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The base
Axes._make_twin_axes
is missing this locator-copying line--maybe that is a bug.