API: only support python 3.5+ #10425

tacaswell · 2018-02-12T03:42:12Z

Matplotlib 3.0 will not support python2.7

QuLogic · 2018-02-12T03:44:11Z

.travis.yml

@@ -111,7 +111,9 @@ before_install:
    else
      brew update
      brew tap homebrew/gui
-      brew install python libpng ffmpeg imagemagick mplayer ccache
+      brew install python3 libpng ffmpeg imagemagick mplayer ccache
+      # make 'python' mean 'pyhon3'


It would not be a PR from me with out a misspelling!

QuLogic · 2018-02-12T04:50:48Z

.circleci/config.yml

@@ -115,9 +115,9 @@ jobs:
          name: "Deploy new docs"
          command: ./.circleci/deploy-docs.sh

-  docs-python27:
+  docs-python3.5:


dstansby · 2018-02-12T10:08:02Z

Should we leave this until 2.2 is out? (otherwise PRs to fix stuff in 2.2 won't get run on py27 CI)

tacaswell · 2018-02-12T13:40:44Z

The 2.2.x branch will still have the current CI set up. Either make PRs directly to 2.2.x or use the backport bot, either of which will run the CI before we merge.

tacaswell · 2018-02-12T14:30:55Z

There seems to be an issue with py3.5 + np1.7.1 and there is a a sphinx issue in one of the docstrings....

dstansby · 2018-02-12T15:12:05Z

Numpy 1.7 doesn't support py3.5, so I guess it needs bumping: https://docs.scipy.org/doc/numpy/release.html#numpy-1-7-2-release-notes

dstansby · 2018-02-12T15:12:51Z

Looks like 1.10 was the first release to support python 3.5: https://docs.scipy.org/doc/numpy/release.html#numpy-1-10-0-release-notes

tacaswell · 2018-02-12T16:01:49Z

Well, that is exciting!

tacaswell · 2018-02-12T22:07:40Z

@QuLogic 's change also exposed that I failed to convince the OSX version to use the right python.

QuLogic · 2018-02-13T01:11:38Z

Looks like the file already exists:

ln: /usr/local/bin/python: File exists
/usr/local/bin/python
Python 2.7.12

QuLogic · 2018-02-13T02:58:02Z

This is working everywhere but doc builds. The 3.6 builds need a rebase to get the other fix. The 3.5 build is failing on examples/api/date.py due to some casting error in date2num on NumPy 1.10. It doesn't not work with any 1.10 micro release but works again with 1.11. That may be due to these changes.

If you rebase, please squash in those two fixup commits of mine (at least).

QuLogic · 2018-02-13T03:20:39Z

Last commit fixes the NumPy date problem, so we just need a rebase for the other doc problem.

jkseppan · 2018-02-13T04:14:27Z

.travis.yml

@@ -126,10 +131,10 @@ install:
    ccache -s
    git describe
    # Upgrade pip and setuptools and wheel to get as clean an install as possible
-    pip install --upgrade pip setuptools wheel
+    python -mpip install --upgrade pip setuptools wheel


Instead of changing all calls to pip to python -mpip it would be easier to change all calls to python to be python3 and all calls to pip to be pip3. That would avoid the need for the symlink.

jkseppan · 2018-02-13T04:19:48Z

.travis.yml

@@ -111,7 +111,12 @@ before_install:
    else
      brew update
      brew tap homebrew/gui


This line causes an error message (that doesn't stop the build): https://travis-ci.org/matplotlib/matplotlib/jobs/340786248#L1724

The line can simply be omitted.

jenshnielsen · 2018-02-13T09:24:53Z

INSTALL.rst

@@ -176,13 +147,9 @@ Matplotlib requires a large number of dependencies:
  * `pytz <http://pytz.sourceforge.net/>`__
  * FreeType (>= 2.3)
  * `cycler <http://matplotlib.org/cycler/>`__ (>= 0.10.0)
-  * `six <https://pypi.python.org/pypi/six>`_


Shouldn't this stay until six is completely removed from the code base

fair, I was being optimistic.

dstansby · 2018-02-13T09:53:13Z

I've just rebased and force pushed to hopefully fix the documentation errors.

Matplotlib 3.0 will not support python2.7

This change is based on the work that IPython did for their transition to Python 3-only [1]. [1] https://www.youtube.com/watch?v=2DkfPzWWC2Q

tacaswell · 2018-02-13T13:58:31Z

squashed the commits as @QuLogic asked, put six back as a dependency and force-pushed.

anntzer · 2018-02-13T15:57:11Z

lib/matplotlib/__init__.py

@@ -99,6 +99,8 @@
 to MATLAB&reg;, a registered trademark of The MathWorks, Inc.

 """
+# NOTE: This file must remain Python 2 compatible for the forseeable future,
+# to ensure that we error out properly for existing editable installs.


In that case it may be worth having a test entry that just tries to python2 -mcompileall matplotlib/__init__.py (or similar) to check that indeed the file is Py2-compatible (otherwise I'm sure it'll quickly break).

anntzer · 2018-02-13T15:58:55Z

setup.py

@@ -3,6 +3,9 @@
 setup.cfg.template for more information.
 """

+# NOTE: This file must remain Python 2 compatible for the forseeable future,
+# to ensure that we error out properly for people with outdated setuptools
+# and/or pip.


I would just move the version check here and allow setupext to use Py3.

dstansby · 2018-02-14T11:14:45Z

Since me and @jkseppan have approved, I'm going to merge so this doesn't hold up other 3.0 PRs.

tacaswell added this to the v3.0 milestone Feb 12, 2018

tacaswell added the API: changes label Feb 12, 2018

QuLogic reviewed Feb 12, 2018

View reviewed changes

tacaswell force-pushed the API_py3_only branch from cc89ae3 to 2d6af56 Compare February 12, 2018 04:30

QuLogic reviewed Feb 12, 2018

View reviewed changes

tacaswell force-pushed the API_py3_only branch from 2d6af56 to acd1929 Compare February 12, 2018 13:32

tacaswell force-pushed the API_py3_only branch from ae6e5b2 to f8cafce Compare February 12, 2018 20:09

jkseppan reviewed Feb 13, 2018

View reviewed changes

jenshnielsen reviewed Feb 13, 2018

View reviewed changes

dstansby force-pushed the API_py3_only branch from 10503e6 to ff7ac98 Compare February 13, 2018 09:52

tacaswell and others added 7 commits February 13, 2018 08:57

API: only support python 3.5+

579726c

Matplotlib 3.0 will not support python2.7

TST: use python -mpip instead of pip

2cac22c

API: bump minimum numpy version to minimum that supports 3.5

e3442ae

Require Python 3 for installation.

c36902c

This change is based on the work that IPython did for their transition to Python 3-only [1]. [1] https://www.youtube.com/watch?v=2DkfPzWWC2Q

Bump minimum numpy on circleci

b1ffc81

TST: use python -mpytest instead of pytest

fc4ace6

Add datetime64 workaround for NumPy 1.10.

08b5466

tacaswell force-pushed the API_py3_only branch from ff7ac98 to 08b5466 Compare February 13, 2018 13:57

CI: remove extraneous line

60cc718

dstansby approved these changes Feb 13, 2018

View reviewed changes

tacaswell mentioned this pull request Feb 13, 2018

mkdir is in the stdlib in Py3. #10439

Merged

6 tasks

anntzer reviewed Feb 13, 2018

View reviewed changes

jkseppan approved these changes Feb 13, 2018

View reviewed changes

dstansby merged commit b17c66f into matplotlib:master Feb 14, 2018

tacaswell deleted the API_py3_only branch February 14, 2018 14:40

QuLogic mentioned this pull request Feb 15, 2018

Remove Python 2 code from setup #10470

Merged

1 task

QuLogic added the Py3k label Feb 18, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

API: only support python 3.5+ #10425

API: only support python 3.5+ #10425

tacaswell commented Feb 12, 2018

QuLogic Feb 12, 2018

tacaswell Feb 12, 2018

QuLogic Feb 12, 2018

dstansby commented Feb 12, 2018

tacaswell commented Feb 12, 2018

tacaswell commented Feb 12, 2018

dstansby commented Feb 12, 2018

dstansby commented Feb 12, 2018

tacaswell commented Feb 12, 2018

tacaswell commented Feb 12, 2018

QuLogic commented Feb 13, 2018

QuLogic commented Feb 13, 2018

QuLogic commented Feb 13, 2018

jkseppan Feb 13, 2018

jkseppan Feb 13, 2018

jenshnielsen Feb 13, 2018 •

edited

Loading

tacaswell Feb 13, 2018

dstansby commented Feb 13, 2018

tacaswell commented Feb 13, 2018

anntzer Feb 13, 2018 •

edited

Loading

anntzer Feb 13, 2018

dstansby commented Feb 14, 2018

API: only support python 3.5+ #10425

API: only support python 3.5+ #10425

Conversation

tacaswell commented Feb 12, 2018

QuLogic Feb 12, 2018

Choose a reason for hiding this comment

tacaswell Feb 12, 2018

Choose a reason for hiding this comment

QuLogic Feb 12, 2018

Choose a reason for hiding this comment

dstansby commented Feb 12, 2018

tacaswell commented Feb 12, 2018

tacaswell commented Feb 12, 2018

dstansby commented Feb 12, 2018

dstansby commented Feb 12, 2018

tacaswell commented Feb 12, 2018

tacaswell commented Feb 12, 2018

QuLogic commented Feb 13, 2018

QuLogic commented Feb 13, 2018

QuLogic commented Feb 13, 2018

jkseppan Feb 13, 2018

Choose a reason for hiding this comment

jkseppan Feb 13, 2018

Choose a reason for hiding this comment

jenshnielsen Feb 13, 2018 • edited Loading

Choose a reason for hiding this comment

tacaswell Feb 13, 2018

Choose a reason for hiding this comment

dstansby commented Feb 13, 2018

tacaswell commented Feb 13, 2018

anntzer Feb 13, 2018 • edited Loading

Choose a reason for hiding this comment

anntzer Feb 13, 2018

Choose a reason for hiding this comment

dstansby commented Feb 14, 2018

jenshnielsen Feb 13, 2018 •

edited

Loading

anntzer Feb 13, 2018 •

edited

Loading