Delete deprecated backends #10426

QuLogic · 2018-02-12T03:56:01Z

PR Summary

Remove GDK, GTK2, and WX backends, plus all deprecated methods in the backends. I need to go through a few of the examples to make sure they're okay.

PR Checklist

Has Pytest style unit tests
Code is PEP 8 compliant
New features are documented, with examples if plot related
Documentation is sphinx and numpydoc compliant
Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

tacaswell · 2018-02-12T04:25:16Z

Can we hold off on doing WX? @DietmarSchwertberger is interested in keeping it up.

QuLogic · 2018-02-12T04:29:45Z

WX or WXAgg (which was not deprecated before)?

QuLogic · 2018-02-12T05:13:36Z

OK, I restored backend_wx.py for now as it's imported in backend_wxagg.py, so we still need it at least partially. I'll leave it to @DietmarSchwertberger to determine whether to remove anything from there.

There's one example lineprops_dialog_gtk_sgskip.py which uses DialogLineprops from the GTK2 backend, but this is not implemented in GTK3. I'm not sure whether this dialog should be implemented for GTK3 as well or the example deleted?

DietmarSchwertberger · 2018-02-12T07:41:46Z

Thanks. I would be fine with a deprecation message for 3.0 for backend_wx..
By then, things should be decided.

QuLogic · 2018-02-12T07:45:32Z

The WX renderer was already deprecated in 2.0, but not WXAgg's. However, backend_wxagg.py uses backend_wx.py. It doesn't look like the renderer is imported, so maybe only the renderer needs to be removed?

DietmarSchwertberger · 2018-02-16T21:48:36Z

Removing just the WX renderer would make backend_wx.py unusable on it's own, even though it could be imported.
Before 3.0 I would like to try whether the WX renderer can be used for rendering to wx.MetaFileDCs for creating EMF/WMF files. If that's not possible, it should be removed then. No matter what the outcome is, the WX backends will need restructuring for 3.0.
I would suggest not to do it for 2.2 as the risk for bugs is quite significant due to the tight schedule. (There are currently unmerged bugfix PRs.)

QuLogic · 2018-02-16T23:41:14Z

This PR is about 3.0, but the wx changes are reverted in any case.

DietmarSchwertberger · 2018-02-17T00:06:02Z

Sorry, did not see this. I just had in mind that the Wx backend was deprecated for rev. 2 already.
I will take care for restructuring / clean up in time for 3.0.

anntzer · 2018-02-17T05:32:30Z

examples/user_interfaces/pylab_with_gtk_sgskip.py

-import gtk
+import gi
+gi.require_version('Gtk', '3.0')
+from gi.repository import Gtk


rename "next" below to something else e.g. pos?

anntzer · 2018-02-17T05:34:14Z

examples/widgets/cursor.py

@@ -20,7 +20,7 @@
 ax.set_xlim(-2, 2)
 ax.set_ylim(-2, 2)

-# set useblit = True on gtkagg for enhanced performance
+# Set useblit=True on some backends for enhanced performance.


"useblit=True" improves the performance on most backends? (gtk3cairo (fundamentally) cannot support blitting and I'm not sure what the situation is with nbagg but all other major backends do support blitting.)

anntzer · 2018-02-17T05:34:28Z

examples/widgets/span_selector.py

@@ -38,7 +38,7 @@ def onselect(xmin, xmax):
    ax2.set_ylim(thisy.min(), thisy.max())
    fig.canvas.draw()

-# set useblit True on gtkagg for enhanced performance
+# Set useblit=True on some backends for enhanced performance.


anntzer · 2018-02-17T05:36:26Z

lib/matplotlib/pyplot.py

-            ml = gobject.MainLoop
+    elif 'gtk' in sys.modules and 'gi' in sys.modules:
+        from gi.repository import GObject
+        ml = GObject.MainLoop


squish into the next line?

anntzer

minor stuff but not blocking merge

QuLogic · 2018-02-17T07:55:46Z

Fixed comments.

QuLogic · 2018-02-19T21:09:56Z

Rebased due to conflicts.

QuLogic · 2018-02-21T08:37:58Z

Rebased due to conflicts.

efiring · 2018-02-25T21:47:33Z

It looks like we want to resolve the conflict by going with the master version, correct?

QuLogic · 2018-02-25T21:54:00Z

Partly, we can still drop this Toolbar class that was deprecated (and now removed) in all backends.

QuLogic · 2018-02-27T08:43:18Z

Rebased due to conflicts.

This silences a warning from PyGI.

It was part of the GTK2 backends, but not implemented for GTK3. This file doesn't load in current Glade either.

QuLogic added this to the v3.0 milestone Feb 12, 2018

QuLogic force-pushed the delete-backends branch from cbf3cfd to 4e5526b Compare February 12, 2018 05:11

QuLogic force-pushed the delete-backends branch 2 times, most recently from 6eff87e to 4c4fc0e Compare February 12, 2018 06:01

QuLogic force-pushed the delete-backends branch from 4c4fc0e to 5d4cf07 Compare February 15, 2018 04:19

QuLogic changed the title ~~WIP: Delete deprecated backends~~ Delete deprecated backends Feb 15, 2018

QuLogic mentioned this pull request Feb 15, 2018

Fix some C++ warnings #10383

Merged

2 tasks

QuLogic mentioned this pull request Feb 17, 2018

Remove Python 2 code from C extensions #10507

Merged

1 task

QuLogic force-pushed the delete-backends branch from 3177ab9 to b33dc6f Compare February 17, 2018 04:58

anntzer reviewed Feb 17, 2018

View reviewed changes

anntzer approved these changes Feb 17, 2018

View reviewed changes

QuLogic force-pushed the delete-backends branch from 34c6162 to 91826bc Compare February 19, 2018 21:09

QuLogic force-pushed the delete-backends branch from 91826bc to e1952aa Compare February 21, 2018 08:37

QuLogic force-pushed the delete-backends branch from e1952aa to 8c51a8d Compare February 25, 2018 21:54

QuLogic mentioned this pull request Feb 26, 2018

Random image failures with test_curvelinear4 #10602

Closed

auvipy approved these changes Feb 27, 2018

View reviewed changes

QuLogic force-pushed the delete-backends branch from 8c51a8d to c8426c6 Compare February 27, 2018 08:43

QuLogic added 10 commits March 3, 2018 21:11

Delete GTK2 embedding examples.

1d45632

Explicitly require GTK 3.0 in GTK3 examples.

c0324d8

This silences a warning from PyGI.

Remove deprecated backend methods.

34f6099

Remove deprecated backends.

40e3879

DOC: Convert remaining GTK2 examples to GTK3.

56947bd

Remove unused lineprops glade file.

962388f

It was part of the GTK2 backends, but not implemented for GTK3. This file doesn't load in current Glade either.

Update GTK example in the docs to GTK3.

5d57a87

Remove reference to delete gtktools toolkit.

c4c40d0

DOC: Add note that deprecated backends were removed.

4987e3c

Fix review items.

d6e93a3

QuLogic force-pushed the delete-backends branch from c8426c6 to d6e93a3 Compare March 4, 2018 02:12

QuLogic mentioned this pull request Mar 5, 2018

Small fixes to gtk3 examples. #10679

Closed

6 tasks

efiring approved these changes Mar 5, 2018

View reviewed changes

efiring merged commit 42055ad into matplotlib:master Mar 5, 2018

QuLogic deleted the delete-backends branch March 5, 2018 03:50

This was referenced May 15, 2018

tkcairo backend #10436

Merged

Some API removals not documented #11252

Closed

ianthomas23 mentioned this pull request Mar 11, 2024

gtk/GTKAgg matplotlib backend is not available ipython/ipython#14368

Closed

chrishavlin mentioned this pull request Mar 20, 2025

Use matplotlib backend registry when possible yt-project/yt#5141

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Delete deprecated backends #10426

Delete deprecated backends #10426

QuLogic commented Feb 12, 2018 •

edited

Loading

tacaswell commented Feb 12, 2018

QuLogic commented Feb 12, 2018

QuLogic commented Feb 12, 2018

DietmarSchwertberger commented Feb 12, 2018

QuLogic commented Feb 12, 2018 •

edited

Loading

DietmarSchwertberger commented Feb 16, 2018

QuLogic commented Feb 16, 2018

DietmarSchwertberger commented Feb 17, 2018

anntzer Feb 17, 2018

anntzer Feb 17, 2018

anntzer Feb 17, 2018

anntzer Feb 17, 2018

anntzer left a comment

QuLogic commented Feb 17, 2018

QuLogic commented Feb 19, 2018

QuLogic commented Feb 21, 2018

efiring commented Feb 25, 2018

QuLogic commented Feb 25, 2018

QuLogic commented Feb 27, 2018

Delete deprecated backends #10426

Delete deprecated backends #10426

Conversation

QuLogic commented Feb 12, 2018 • edited Loading

PR Summary

PR Checklist

tacaswell commented Feb 12, 2018

QuLogic commented Feb 12, 2018

QuLogic commented Feb 12, 2018

DietmarSchwertberger commented Feb 12, 2018

QuLogic commented Feb 12, 2018 • edited Loading

DietmarSchwertberger commented Feb 16, 2018

QuLogic commented Feb 16, 2018

DietmarSchwertberger commented Feb 17, 2018

anntzer Feb 17, 2018

Choose a reason for hiding this comment

anntzer Feb 17, 2018

Choose a reason for hiding this comment

anntzer Feb 17, 2018

Choose a reason for hiding this comment

anntzer Feb 17, 2018

Choose a reason for hiding this comment

anntzer left a comment

Choose a reason for hiding this comment

QuLogic commented Feb 17, 2018

QuLogic commented Feb 19, 2018

QuLogic commented Feb 21, 2018

efiring commented Feb 25, 2018

QuLogic commented Feb 25, 2018

QuLogic commented Feb 27, 2018

QuLogic commented Feb 12, 2018 •

edited

Loading

QuLogic commented Feb 12, 2018 •

edited

Loading