Skip to content

Add canonical link to webpages #10440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2018
Merged

Conversation

dstansby
Copy link
Member

This should stop google indexing devdocs or old versions of the docs. Fixes #9065.

@tacaswell tacaswell added this to the v2.2-doc milestone Feb 13, 2018
@tacaswell
Copy link
Member

Does {{pagename}} include the full relative url path?

@dstansby
Copy link
Member Author

I'm not sure, I'll wait for circleci to build and check the source of the pages it generates.

@dstansby
Copy link
Member Author

Yep, this is working fine. The canonical URLs in the circleci build link to the current stable docs.

@timhoffm timhoffm merged commit 86514a2 into matplotlib:master Feb 13, 2018
@dstansby dstansby deleted the canonical-link branch February 13, 2018 21:06
@QuLogic
Copy link
Member

QuLogic commented Feb 13, 2018

@Carreau still not backporting... Maybe it's because two milestones are backporting to the same branch?

@Carreau
Copy link
Contributor

Carreau commented Feb 13, 2018

@Carreau still not backporting... Maybe it's because two milestones are backporting to the same branch?

No in this particular case it's because meeseeks dev ignores @timhoffm who is not white listed (fixed).
Still have no clue why it rejected others.

@QuLogic
Copy link
Member

QuLogic commented Feb 13, 2018

@meeseeksdev backport to v2.2.x

lumberbot-app bot pushed a commit that referenced this pull request Feb 13, 2018
tacaswell added a commit that referenced this pull request Feb 14, 2018
@QuLogic QuLogic modified the milestones: v2.2-doc, v2.2.0 Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants