Skip to content

renaming duplicated file names #10451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2018
Merged

renaming duplicated file names #10451

merged 1 commit into from
Feb 16, 2018

Conversation

choldgraf
Copy link
Contributor

PR Summary

This renames a few examples/tutorials that have duplicated filenames in matplotlib. Partially since it's best-practice, but also because whenever sphinx-gallery releases a new version we'll be able to include Binder links in all the examples and it'll throw a warning if we have duplicated examples/tutorials names.

@tacaswell tacaswell added this to the v2.2-doc milestone Feb 14, 2018
@tacaswell
Copy link
Member

You probably need to adjust pytest.ini to skip checking the right examples.

@choldgraf choldgraf force-pushed the rename_duplicates branch 5 times, most recently from 55b76f7 to 3502fba Compare February 14, 2018 20:32
@choldgraf
Copy link
Contributor Author

@tacaswell any idea why this would fail on Circle 2.7 but not on 3.5?

@QuLogic
Copy link
Member

QuLogic commented Feb 15, 2018

Because 2.7 runs linkchecker and you've got a broken link somewhere:

URL        `_images/sphx_glr_animated_histogram_thumb1.png'
Name       `screenshots'
Parent URL file:///home/circleci/project/doc/build/html/index.html, line 121, col 7
Real URL   file:///home/circleci/project/doc/build/html/_images/sphx_glr_animated_histogram_thumb1.png
Check time 0.002 seconds
Result     Error: URLError: <urlopen error [Errno 2] No such file or directory: '/home/circleci/project/doc/build/html/_images/sphx_glr_animated_histogram_thumb1.png'>

@choldgraf
Copy link
Contributor Author

looks like linkchecking is happy now!

@tacaswell tacaswell merged commit d8f8a0e into matplotlib:master Feb 16, 2018
lumberbot-app bot pushed a commit that referenced this pull request Feb 16, 2018
@tacaswell
Backport PR #10451: renaming duplicated file names
d672a2c
@lumberbot-app lumberbot-app bot mentioned this pull request Feb 16, 2018
Merged
dstansby added a commit that referenced this pull request Feb 16, 2018
@dstansby
Merge pull request #10499 from matplotlib/auto-backport-of-pr-10451
70ba990 
Backport PR #10451 on branch v2.2.x
@QuLogic QuLogic modified the milestones: v2.2-doc, v2.2.0 Feb 16, 2018
@QuLogic QuLogic mentioned this pull request Jun 10, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@choldgraf @tacaswell @QuLogic @dstansby