Skip to content

Move some examples out of examples/api #10459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 29, 2018
Merged

Conversation

dstansby
Copy link
Member

Goes halfway towards solving #5571 by moving stuff out of examples/api into better categories. I got bored, and short PRs make for easier review, so I'll put the rest in another PR at some point (unless someone else wants to 😉 )

@tacaswell tacaswell added this to the v2.2-doc milestone Feb 14, 2018
@QuLogic
Copy link
Member

QuLogic commented Feb 14, 2018

Looks like there are a few cross-references that need updating.

@@ -1,23 +0,0 @@
"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this example ("pyplot-free mpl") is actually worth keeping.

Copy link
Contributor

@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dstansby dstansby force-pushed the api-examples branch 2 times, most recently from 88b0c72 to 24085dd Compare February 23, 2018 18:47
@anntzer anntzer dismissed their stale review February 23, 2018 19:10

comment handled

Fix some doc links

Put back AGG OO example

Remove old example
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks OK to me.

@@ -7,6 +7,7 @@
to leave out days on which there is no data, i.e. weekends. The example
below shows how to use an 'index formatter' to achieve the desired plot
"""
from __future__ import print_function
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be added now since we're Python 3 only on master.

@anntzer anntzer merged commit d84d779 into matplotlib:master Mar 29, 2018
QuLogic added a commit that referenced this pull request Mar 30, 2018
@dstansby dstansby deleted the api-examples branch March 30, 2018 07:29
@ImportanceOfBeingErnest
Copy link
Member

I think this PR led to the fact that there are now two date_index_formatter.py examples

  • matplotlib/examples/text_labels_and_annotations/date_index_formatter.py [link to docs]
  • matplotlib/examples/ticks_and_spines/date_index_formatter.py [link to docs]

which seem to be doing similar things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants