DOC: Add cividis to the tutorial about colormaps #10463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the order is fine as-is. Thanks! |
|
@tacaswell Fair enough ;). |
phobson
added a commit
that referenced
this pull request
Feb 14, 2018
Backport PR #10463 on branch v2.2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
It seems like the existence of the tutorial about colormaps was forgotten by #9871 :).
Note that I used the same order as in #9871 (i.e.
['viridis', 'plasma', 'inferno', 'magma', 'cividis']) for consistency sake, but I wonder if['viridis', 'plasma', 'cividis', 'inferno', 'magma']may actually be more “logical”: 'cividis' was designed to be similar to 'viridis' and 'plasma' rather than 'inferno' and 'magma', was it not?PR Checklist