DOC: Expending a bit about the "tableau-colorblind10" entry in What's new #10473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstansby
approved these changes
Feb 15, 2018
lumberbot-app bot
pushed a commit
that referenced
this pull request
Feb 16, 2018
…d10" entry in What's new
QuLogic
added a commit
that referenced
this pull request
Feb 16, 2018
Backport PR #10473 on branch v2.2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
As it took me several readings to understand how to load the new “tableau-colorblind10” color cycle, I would suggest slightly expanding the entry about it in the What's new section, to be more explicit. I guess it cannot really hurt if we want to promote that new color cycle.
On a technical note, I was originally planning to use a versionned URL, but it seems that “https://matplotlib.org/2.2.0/*“ does not exist yet :/, does it?
Disclaimer: Hopefully I got the RST syntax right. I simply followed patterns found in other places of the file, and did not build the full documentation locally.
@tacaswell I apologize in advance if it would have been better not to edit the
whats_new.rstfile, but instead to create a new separate entry file that you would have used to update the relevant entry. My genuine reasoning was that it is more a fix than a new entry.