Remove the 'hold' kwarg from codebase #10485
Conversation
lib/matplotlib/pyplot.py
Outdated
|
|
||
| return ret | ||
|
|
||
| # Autogenerated by boilerplate.py. Do not edit as changes will be lost. | ||
| @_autogen_docstring(Axes.angle_spectrum) | ||
| def angle_spectrum(x, Fs=None, Fc=None, window=None, pad_to=None, sides=None, | ||
| hold=None, data=None, **kwargs): | ||
| **kwargs): |
There was a problem hiding this comment.
Note to future me: the data kwarg shouldn't have gone here, this needs fixing. (or if anyone fancies force pushing a fix to my branch)
0b57492 to
862aba8
Compare
|
The +/- on this PR is amazing! |
fe078de to
32b8a0a
Compare
|
I think this is somewhat covered by #9173, though it's a bit old and has some conflicts. |
32b8a0a to
2cb27d1
Compare
|
I'll need to revisit #9173 anyways, so no worries. |
|
Just needs API changes docs! |
| %(ret)s = %(ax)s.%(func)s(%(call)s) | ||
| finally: | ||
| %(ax)s._hold = %(washold)s | ||
| %(ret)s = %(ax)s.%(func)s(%(call)s) |
There was a problem hiding this comment.
Even simpler would be to just do return gca().func(...), which avoids the need for temporary variables and thus allows you to get rid of the "gensym-like facility" mentioned lower in this script.
There was a problem hiding this comment.
👍 the only reason we needed the local reference to the return value was so we could reset the hold.
Fix data kwarg Fix contour boilerplating Remove last bits of _hold
|
Still a few fixes applicable but let's get this in first. |
Another step in to the bright new post python 2.7 world, this time removing the
holdkwarg. As far as I can see I've got rid of all the_holdinstances in the code base. Lets see what happens with the tests...