Skip to content

Move some logging calls down to DEBUG level. #10509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2018
Merged

Move some logging calls down to DEBUG level. #10509

merged 1 commit into from
Feb 19, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Feb 17, 2018

The idea is that a "normal" import of matplotlib should not trigger log
calls above the DEBUG level, see #10281 for rationale.

I'm allowing myself to tag this as release critical for 2.2 based on the same rationale as #10281, but feel free to disagree.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Move some logging calls down to DEBUG level.
b4bed78 
The idea is that a "normal" import of matplotlib should not trigger log
calls above the DEBUG level.
@anntzer anntzer added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Feb 17, 2018
@anntzer anntzer added this to the v2.2.0 milestone Feb 17, 2018
@tacaswell tacaswell merged commit a0e91e1 into matplotlib:master Feb 19, 2018
lumberbot-app bot pushed a commit that referenced this pull request Feb 19, 2018
@tacaswell
Backport PR #10509: Move some logging calls down to DEBUG level.
560f5c7
@lumberbot-app lumberbot-app bot mentioned this pull request Feb 19, 2018
Merged
tacaswell added a commit that referenced this pull request Feb 19, 2018
@tacaswell
Merge pull request #10535 from matplotlib/auto-backport-of-pr-10509
8e3e437 
Backport PR #10509 on branch v2.2.x
@anntzer anntzer deleted the loglevels branch February 19, 2018 22:24
@anntzer anntzer mentioned this pull request Aug 28, 2018
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efiring efiring efiring approved these changes

Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @efiring @tacaswell