Skip to content

Tell flake8 to ignore false alarms from #10502 #10510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Tell flake8 to ignore false alarms from #10502 #10510

wants to merge 1 commit into from

Conversation

cclauss
Copy link

@cclauss cclauss commented Feb 17, 2018

Fixes #10502

@dstansby
Copy link
Member

I'm -1 on this change, since we don't use flake8 as a tool and it's just a messy comment. If someone else agrees, I think this should be closed.

@tacaswell
Copy link
Member

I'm also 👎 on using #noqa.

I think a better solution is to throw a FigureManger = None # replaced by decorator or such at the top or just ignore flake8.

@cclauss cclauss closed this Feb 18, 2018
@cclauss cclauss deleted the patch-1 branch February 18, 2018 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cclauss @dstansby @tacaswell