Py3fy font_manager. #10522
Py3fy font_manager. #10522
Conversation
|
Looks correct to me. Did you test the changed code on Windows? The codecov output seems to indicate a lack of automated test coverage. On the other hand, a lot of the time the codecov results look just completely wrong. |
|
Can't easily test on Windows right now, sorry. |
| stretch = 'semi-condensed' | ||
| elif fontname.find('wide') >= 0 or fontname.find('expanded') >= 0: | ||
| elif 'narrow' in fontname or 'cond' in fontname: |
There was a problem hiding this comment.
Why have these if statements swapped order?
There was a problem hiding this comment.
the search for "demi cond" has to go before the search for "cond" (otherwise the latter always happens before the former...).
| @@ -568,7 +544,7 @@ def createFontList(fontfiles, fontext='ttf'): | |||
| except UnicodeError: | |||
| _log.info("Cannot handle unicode filenames") | |||
| continue | |||
| except IOError: | |||
| except OSError: | |||
| _log.info("IO error - cannot open font file %s", fpath) | |||
There was a problem hiding this comment.
If its now an OSError should this message be changed, or is it obvious enough?
There was a problem hiding this comment.
Well, from the POV of the user it is indeed an input/output error... (and IOError == OSError anyways on Py3)
PR Summary
(orthogonal to #10435)
PR Checklist