Skip to content

FIX: No rcparam minor ticks in colorbar #8358 #10530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

FIX: No rcparam minor ticks in colorbar #8358 #10530

wants to merge 3 commits into from

Conversation

Dih5
Copy link

@Dih5 Dih5 commented Feb 19, 2018

PR Summary

Fixes #8358. Minor ticks were shown in colorbars when the ytick.minor.visible rcParam is True. A user won't be regarding a colorbar as a y axis, so this is a bug and not a feature 😉
This PR forces removal of the minor ticks on the axes of a colorbar when its created. A image comparison test is also provided.

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@jklymak
Copy link
Member

jklymak commented Feb 19, 2018

#9903 also addresses this.

@Dih5
Copy link
Author

Dih5 commented Feb 19, 2018

I notice now that minor ticks should not be hidden by default in linear scale, so my fix is not good!
Please, consider checking #8358 is fixed in #9903, that seems proper way to address the problem.

@Dih5 Dih5 closed this Feb 19, 2018
@jklymak
Copy link
Member

jklymak commented Feb 19, 2018

Well #9903 is pretty radical change to colorbars so it may not get in. So an interim fix to this problem might be a good idea I don’t have the time to check right now but will try to remember later if #9903 fixes that issue.

@Dih5 Dih5 reopened this Feb 19, 2018
@Dih5
Copy link
Author

Dih5 commented Feb 19, 2018

I updated the changes to apply only with Log/SymLog normalizations. I hope for #9903 to make it eventually, but in the meantime perhaps this might solve the issue.

@Dih5
Copy link
Author

Dih5 commented Mar 23, 2018

Now that #9903 has been merged, there is no need for this PR. Thanks to @jklymak for this great job 🎉

@Dih5 Dih5 closed this Mar 23, 2018
@Dih5 Dih5 deleted the fix-rcminorticks-colorbar branch March 23, 2018 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minor ticks on log-scale colorbar are not cleared
2 participants
@Dih5 @jklymak