Skip to content

Use np.full{,_like} where appropriate. [requires numpy>=1.12] #10571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Use np.full{,_like} where appropriate. [requires numpy>=1.12] #10571

wants to merge 1 commit into from

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Feb 23, 2018 •
edited
Loading

PR Summary

This PR would require a bump of the minimum numpy version to 1.12, where the return dtype of np.full was change to default to the fill-value's dtype (https://github.com/numpy/numpy/blob/master/doc/release/1.12.0-notes.rst).

Closing until numpy version is bumped.

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.0 milestone Feb 23, 2018
@anntzer anntzer self-assigned this Mar 29, 2018
@anntzer anntzer closed this Mar 29, 2018
@anntzer anntzer changed the title Use np.full{,_like} where appropriate. Use np.full{,_like} where appropriate. [requires numpy>=1.12] Mar 29, 2018
@anntzer anntzer mentioned this pull request Oct 3, 2018
Merged
@anntzer anntzer mentioned this pull request Oct 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@anntzer anntzer

Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@anntzer