Remove some manual manipulation of whatsnew when releasing. #10573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiring
approved these changes
Mar 5, 2018
|
rebased |
78d9dbd to
e37028c
Compare
|
Should the doc builds not work? |
|
Can't reproduce the failure locally (the whatsnew gets included)... |
|
I suspect a rebase will fix this; I had this error for something as well that shouldn't have had the error, but it worked after a rebase? |
|
rebased |
|
Can you extend this to api_changes too? |
This PR ensures that the "unmerged" whatsnew entries get included in the docs if and only if we're building the docs for a "local release", i.e. when the version number includes a git tag, but not a tagged release. This previously required manual manipulation.
|
Done. (but I guess it may still make sense to wait until the issue is fixed on sphinx's side before merging this, so that we don't start universally failing doc builds...) |
|
Temporarily closing until the issue is fixed upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that the "unmerged" whatsnew entries get included in the
docs if and only if we're building the docs for a "local release", i.e.
when the version number includes a git tag, but not a tagged release.
This previously required manual manipulation.
Noted while reviewing #10548.
PR Summary
PR Checklist