Cleanup and py3fy backend_gtk3. #10621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
966f50a to
761fdb9
Compare
dstansby
reviewed
Feb 27, 2018
|
|
||
| hbox.show_all() | ||
| self.set_extra_widget(hbox) | ||
|
|
||
| def get_filename_from_user (self): | ||
| @cbook.deprecated("3.0") |
There was a problem hiding this comment.
Could this get sorted(self.filetypes.items()) as an alternative?
There was a problem hiding this comment.
added, but I think this is such an obscure API that I'll skip the note in the deprecation docs.
dstansby
reviewed
Feb 27, 2018
| @@ -340,14 +335,10 @@ def __init__(self, canvas, num): | |||
| self.set_window_title("Figure %d" % num) | |||
| try: | |||
| self.window.set_icon_from_file(window_icon) | |||
| except (SystemExit, KeyboardInterrupt): | |||
There was a problem hiding this comment.
Why are these not being re-raised anymore?
There was a problem hiding this comment.
We now catch Exception, which is everything but SystemExit, KeyboardInterrupt (and GeneratorExit, which is irrelevant here). SystemExit and KeyboardInterrupt are not caught at all and just get raised normally.
_pixmapBack was never used on the GTK3 backend (it only exists in the old GTK2 backend).
761fdb9 to
249df18
Compare
dstansby
approved these changes
Feb 27, 2018
timhoffm
approved these changes
Feb 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_pixmapBack was never used on the GTK3 backend (it only exists in the
old GTK2 backend).
PR Summary
PR Checklist