Support markers from Paths that consist of one line segment #10632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `elif` clauses in `Marker.set_marker` needed to be reordered because any Python object that has a `__len__` method is an instance of `collections.Sized`.
anntzer
approved these changes
Feb 28, 2018
phobson
approved these changes
Mar 2, 2018
|
I think this fixes a bug and a regression to 1.x versions. Should be put in the 2.2 branch as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
elifclauses inMarker.set_markerneeded to be reordered because any Python object that has a__len__method is an instance ofcollections.Sized.Before this change, the new unit test
test_marker_path()would fail with this exception: