Skip to content

More figure-related doc updates #10666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2018

Conversation

timhoffm
Copy link
Member

@timhoffm timhoffm commented Mar 4, 2018

PR Summary

Docstring updates.

@dstansby dstansby added this to the v2.2.1 milestone Mar 5, 2018
@dstansby dstansby merged commit 5df8380 into matplotlib:master Mar 5, 2018
@lumberbot-app
Copy link

lumberbot-app bot commented Mar 5, 2018

There seem to be a conflict, please backport manually

@timhoffm
Copy link
Member Author

timhoffm commented Mar 5, 2018

Is there a description somewhere how to do a manual backport?

@dstansby
Copy link
Member

dstansby commented Mar 6, 2018

timhoffm pushed a commit that referenced this pull request Mar 18, 2018
@timhoffm
Copy link
Member Author

Manually backported to v2.2.2-doc
68beb9a

@timhoffm timhoffm deleted the doc-figure-part-2 branch March 18, 2018 00:38
@QuLogic
Copy link
Member

QuLogic commented Mar 18, 2018

For the future, the -doc branch is only for .rst file changes.

@QuLogic QuLogic modified the milestones: v2.2.1, v2.2-doc Mar 18, 2018
@timhoffm
Copy link
Member Author

Ok, should I backport it to 2.2.x as well or is it tolerable as it is now this one time?

@QuLogic
Copy link
Member

QuLogic commented Mar 18, 2018

v2.2.2-doc will be merged into v2.2.x, so there's no need to do any more cherry-picking.

@tacaswell tacaswell modified the milestones: v2.2-doc, v3.0 Mar 18, 2018
@tacaswell
Copy link
Member

This should not have been backported to -doc, I am going to revert that commit.

To build the published docs you install the stable version and then build the docs from the -doc branch so these changes will not reflected in the built docs (see https://matplotlib.org//devel/release_guide.html#build-and-deploy-documentation).

Sorry for not being clearer about this.

Given the discussion at #10822 I am not sure if we want to be backporting docstring changes to 2.2.x.

tacaswell added a commit that referenced this pull request Mar 18, 2018
This reverts commit 68beb9a.

Changes to lib should not be backported to the -doc branch
@tacaswell
Copy link
Member

Reverted in a8ac10d

@timhoffm
Copy link
Member Author

Since the 2.2.x release will probably be the last one for Python 2, it will be around for some time, even after 3.0 is out. I would welcome backporting docstring improvements there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants