Fix tk icon loading. #10681
Merged
Fix tk icon loading. #10681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is the best way to test this just open a plot in a tk window? |
|
Yes |
|
Hmm, I don't get an icon with the fix, but that might be an OSX thing. |
|
It works again, but it's kind of low resolution. |
QuLogic
approved these changes
Mar 5, 2018
jklymak
approved these changes
Mar 5, 2018
dstansby
added a commit
that referenced
this pull request
Mar 6, 2018
Backport PR #10681 on branch v2.2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accidentally broke this for no good reason in #8773. Milestoning as 2.2 as it's fixing a bug introduced in 2.1.
PR Checklist