Skip to content

FIX/TST constrained_layout remove test8 duplication #10725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2018
Merged

FIX/TST constrained_layout remove test8 duplication #10725

merged 1 commit into from
Mar 16, 2018

Conversation

jklymak
Copy link
Member

@jklymak jklymak commented Mar 8, 2018

PR Summary

closes #10722

Had an extra copy of a test in test_constrainedlayout. Removed, and refactored the test a bit while there.

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant

@jklymak jklymak added topic: geometry manager LayoutEngine, Constrained layout, Tight layout topic: testing labels Mar 8, 2018
@jklymak jklymak added this to the v3.0 milestone Mar 8, 2018
@jklymak
Copy link
Member Author

jklymak commented Mar 13, 2018

I'll ping about this one - its a pretty quick review and will improve the test coverage stats.

@jklymak
Copy link
Member Author

jklymak commented Mar 16, 2018

ping

@anntzer anntzer merged commit bb337ad into matplotlib:master Mar 16, 2018
@jklymak jklymak deleted the fix-tst-constrainedlayout-badtest branch March 16, 2018 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efiring efiring efiring approved these changes

Assignees
No one assigned
Labels
topic: geometry manager LayoutEngine, Constrained layout, Tight layout topic: testing
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

Duplicated test name in test_constrainedlayout
3 participants
@jklymak @efiring @anntzer