Skip to content

Use rcParams to control default "raise window" behavior #10766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kalagau
Copy link
Contributor

@kalagau kalagau commented Mar 13, 2018

PR Summary

PR for issue 8692. The solution currently creates a new rcParam 'figure.show' which is used to suppress the raise window behavior backend_bases.py depending on rcParams.

PR Checklist

  • Has Pytest style unit tests
  • [x ] Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@WeatherGod
Copy link
Member

WeatherGod commented Mar 13, 2018

I think there is a misunderstanding of what the original issue was about. IIRC, the original issue was a question of whether or not a new figure window would take focus or not (i.e., "raise" it to the top of the GUI stack). Having an rcParam to control whether or not the function show() actually shows is very counter-intuitive, and I am -1 on this.

@barsl
Copy link

barsl commented Mar 15, 2018

I agree this PR doesn't address the actual issue, which as said, is about new windows popping to the front of the screen.
I believe users using the show() command will always want to show the figure, although perhaps not in the front.

@kalagau kalagau closed this Mar 15, 2018
@kalagau kalagau deleted the Fix8692 branch March 15, 2018 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants