Skip to content

FIX/TST OS X builds #10771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 13, 2018
Merged

FIX/TST OS X builds #10771

merged 2 commits into from
Mar 13, 2018

Conversation

jklymak
Copy link
Member

@jklymak jklymak commented Mar 13, 2018 •
edited
Loading

PR Summary

Mac builds are failing. Per @anntzer on twitter adding to the os x path to try to get them to build...

Fundamental problem is that python now needs the be python3 if we use homebrew.

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@jklymak
Copy link
Member Author

jklymak commented Mar 13, 2018

Tests running on OSX!

@jklymak jklymak added this to the v3.0 milestone Mar 13, 2018
@anntzer
Copy link
Contributor

anntzer commented Mar 13, 2018

Merging as "unbreak the build".

@anntzer anntzer merged commit ccd6377 into matplotlib:master Mar 13, 2018
@jklymak jklymak deleted the fix-tst-mactravis branch March 13, 2018 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
topic: testing
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jklymak @anntzer