Fix scaling of RadioButtons #10780
Fix scaling of RadioButtons #10780
Conversation
|
Hum, about the failing image test comparison, I would suspect a Freetype issue as it is quite usual. See for example this section in the documentation. On top of that you could try to add |
…e headers to the radio button tests
|
I original thought I was using the correct Freetype, as I set my setup.cfg correctly but realized it wasn't actually using the version mlp wanted. I had to delete my build folder and recompile the project for it to use the correct version #6911. Thank you! |
|
Based on the logs, it looks like CI is failing due to a PEP8 issue because of trailing whitespaces on line 93 of test_widgets.py. |
|
Oh.. I completely missed that. I assume they were just pep8 warnings that were just making me aware that they were there. Thank you @br-Zhang |
PR Summary
This fix scales the radio buttons correctly with the size of the legend by taking the height that is already calculated for each section of the legend, which is defined by the variable dy (line 984). I took the dy value and converted appropriately into a radius (by dividing the value by 2) and subtracting a very small unit to allow for some spacing for in between the buttons. I made it default back into the previously hard-coded value of 0.05 if the value of the radius is any bigger so in the case where there isn't many radio buttons, they wouldn't be huge. Previously the value of the RadioButtons were set to 0.05 thus when the space given for each radio button was less then the 0.05 unit the buttons would overlap onto eachother.
Note: The tests seem to be failing at the image comparison tests for the radio button. Not entirely sure why, the test pass locally on my own machine. Any insight would be helpful, thank you.
PR Checklist