-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
bug fix - set_facecolor/set_edgecolor not working for some 3D artists #10797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug fix - set_facecolor/set_edgecolor not working for some 3D artists #10797
Conversation
rollback docstring to original add a test case
… (the one cause the problem), hopefully it works
Ok, it is taking me some time to think through the implications of this change. It is obvious that this fixes a real problem, so that is a definite plus. My main problem is that these new methods are still not defined in the classes, so only artists that go through this conversion processes (admittedly, that is most of them) will get these special methods defined. This will cause confusion for users, as well as the maintainers because debugging will be harder to do. If you are looking to avoid duplicating code, you are free to make a private mixin class |
@WeatherGod looks like Poly3DCollection was already fixed years ago. should I change it to make the style unified? |
I believe this was superseded by #18189 so I'm closing, but feel free to re-open. Sorry @xiaoshiqi that this never got in, and thanks for your efforts. |
PR Summary
fixed set_facecolor(set_facecolors), set_edgecolor(set_edgecolors), and set_color not working for some 3Dartists
this bug was originally mentioned in #9725
this PR is an extension of my earlier attempt #10489
PR Checklist