Add some basic smoketesting for webagg (and wx). #10823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The missing test coverage is the path that fails the webagg test. |
tacaswell
approved these changes
Mar 18, 2018
|
🎉 on 0.45% coverage increase! |
|
Would actually be even nicer if some websockets expert knows how to send a draw request to the server... |
dopplershift
approved these changes
Mar 19, 2018
|
👍 to more testing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Adds some (smoke)testing for #10708. This basically just checks that the server sets up correctly and closes cleanly on ctrl-c.
If you know how to actually trigger a draw on the websocket (and thus trigger the draw_event handler of the other backends), feel free to push a better method to this PR...
PR Checklist