Skip to content

Propagate marker antialias setting to GraphicsContext. #10833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Mar 18, 2018

The Agg backend still doesn't know how to make use of that information
in draw_markers, but third-party backends (e.g. mplcairo) do honor the
setting.

xref #10825.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

The Agg backend still doesn't know how to make use of that information
in draw_markers, but third-party backends (e.g. mplcairo) do honor the
setting.
@tacaswell tacaswell added this to the v3.0 milestone Mar 18, 2018
@timhoffm timhoffm merged commit ccc35b0 into matplotlib:master Mar 19, 2018
@anntzer anntzer deleted the marker-antialiasing branch March 19, 2018 00:45
@ImportanceOfBeingErnest
Copy link
Member

Does this solve #10825 ? If so, shouldn't the issue be closed? If not, what's left to solve it?

@anntzer
Copy link
Contributor Author

anntzer commented Mar 26, 2018

Only with mplcairo... so the issue should stay open (now Agg gets the info, but I think (TBC?) it doesn't take advantage of it).

@tacaswell tacaswell modified the milestones: v3.0, v2.2.3 Aug 4, 2018
tacaswell pushed a commit to tacaswell/matplotlib that referenced this pull request Aug 4, 2018
Propagate marker antialias setting to GraphicsContext.
@tacaswell
Copy link
Member

backported to v2.2.x as 278ee47 to make #11105 backport cleanly.

Made an executive decision to backport explicitly rather than implicitly by resolving the conflict for #11105 (and keeping this line) or be annoyingly inflexible about backports and delete this line in the other backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants