py3ify table.py and correct some docstrings #10862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
reviewed
Mar 22, 2018
| @@ -461,8 +456,7 @@ def auto_set_column_width(self, col): | |||
| self.stale = True | |||
|
|
|||
| def _auto_set_column_width(self, col, renderer): | |||
| """ Automagically set width for column. | |||
| """ | |||
| """Automatically set width for column.""" | |||
There was a problem hiding this comment.
I think automagically is fine here, we're allowed some humor for private docstrings at least...
There was a problem hiding this comment.
Not sure it was intended, though. All other similar methods around this are using "automatically" and 'g' and 't' are adjacent on the keyboard, so I assume this is just a coincidentally funny typo. If you know this is intentional, I'm happy to revert the change.
There was a problem hiding this comment.
I don't really care tbh, changing is fine.
anntzer
reviewed
Mar 22, 2018
lib/matplotlib/table.py
Outdated
| 'Move all the artists by ox,oy (axes coords)' | ||
|
|
||
| for c in six.itervalues(self._cells): | ||
| """Move all the artists by ox,oy (axes coords).""" |
anntzer
approved these changes
Mar 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary