Skip to content

Rely on rglob support rather than os.walk. #10871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2018
Merged

Rely on rglob support rather than os.walk. #10871

merged 1 commit into from
Mar 26, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Mar 23, 2018 •
edited
Loading

In OSXInstalledFonts, the fontext is None path could never be taken,
because get_fontext_synonyms never returns None.

(edit: I just realized this overlaps with #10435, but not completely so I'll resolve conflicts either way :-))

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added the Py3k label Mar 23, 2018
@anntzer anntzer added this to the v3.0 milestone Mar 23, 2018
@anntzer anntzer force-pushed the rglob branch 4 times, most recently from 7691ea5 to 246021a Compare March 23, 2018 19:06
@anntzer
Rely on rglob support rather than os.walk.
66348a9 
In OSXInstalledFonts, the `fontext is None` path could never be taken,
because `get_fontext_synonyms` never returns None.
@phobson phobson merged commit 84a4e95 into matplotlib:master Mar 26, 2018
@anntzer anntzer deleted the rglob branch March 26, 2018 19:45
@anntzer anntzer mentioned this pull request Sep 26, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @timhoffm @phobson