Skip to content

Fix invalid escape sequence in docstring. #10877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2018
Merged

Fix invalid escape sequence in docstring. #10877

merged 1 commit into from
Mar 25, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Mar 25, 2018

PR Summary

fixes https://github.com/matplotlib/matplotlib/pull/10834/files#r176927952
release critical as that'll be a syntax error in future pythons

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added Documentation Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. labels Mar 25, 2018
@anntzer anntzer mentioned this pull request Mar 25, 2018
Merged
@jklymak
Copy link
Member

jklymak commented Mar 25, 2018

I don't get how it passed the tests. I don't think I'm running python 3.7!

@anntzer
Copy link
Contributor Author

anntzer commented Mar 25, 2018

https://github.com/matplotlib/matplotlib/blob/master/tests.py#L32 if you're using tests.py, otherwise dunno

@QuLogic QuLogic added this to the v3.0 milestone Mar 25, 2018
@QuLogic QuLogic merged commit a4139ae into matplotlib:master Mar 25, 2018
@anntzer anntzer deleted the raw-docstring branch March 25, 2018 04:37
@tacaswell tacaswell modified the milestones: v3.0, v2.2.3 Jul 15, 2018
@tacaswell
Copy link
Member

Hey folks, this needs to be backported as this will become a failure to import error in the future.

@meeseeksdev backport to v2.2.x

lumberbot-app bot pushed a commit that referenced this pull request Jul 15, 2018
@QuLogic
Backport PR #10877: Fix invalid escape sequence in docstring.
7f157b5
@lumberbot-app lumberbot-app bot mentioned this pull request Jul 15, 2018
Merged
@QuLogic
Copy link
Member

QuLogic commented Jul 15, 2018

There are a few more in https://github.com/matplotlib/matplotlib/pull/11477/commits that might be needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
Documentation Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v2.2.3
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @jklymak @tacaswell @QuLogic