Update install instructions for win #10894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklymak
added a commit
that referenced
this pull request
Mar 27, 2018
Backport PR #10894 on branch v2.2.2-doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This is a small update on the install instructions for Windows.
For newer versions of conda the environment variable
%CONDA_DEFAULT_ENV%points to the name of the environment, not the path. Instead%CONDA_PREFIX%points to the path which has to be used for copying the files during the build.This change is correctly reflected in the
build_alllocal.cmdmatplotlib/build_alllocal.cmd
Line 24 in c29d9b2
but the documentation needs to be updated as well; at least if we do not want people to spend an hour trying to figure out what's wrong with their built like I just did.