Skip to content

FIX: return proper legend window extent #10910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2018
Merged

FIX: return proper legend window extent #10910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc32dc4
FIX: return proper legend window extent
jklymak Mar 28, 2018
9a03a2d
TST: check that size changes
jklymak Mar 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/matplotlib/legend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -952,7 +952,7 @@ def get_title(self):

def get_window_extent(self, *args, **kwargs):
'Return extent of the legend.'
return self.legendPatch.get_window_extent(*args, **kwargs)
return self._legend_box.get_window_extent(*args, **kwargs)

def get_frame_on(self):
"""Get whether the legend box patch is drawn."""
Expand Down
14 changes: 14 additions & 0 deletions lib/matplotlib/tests/test_legend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,3 +488,17 @@ def test_legend_title_empty():
leg = ax.legend()
assert leg.get_title().get_text() == ""
assert leg.get_title().get_visible() is False


def test_legend_proper_window_extent():
# test that legend returns the expected extent under various dpi...
fig, ax = plt.subplots(dpi=100)
ax.plot(range(10), label='Aardvark')
leg = ax.legend()
x01 = leg.get_window_extent(fig.canvas.get_renderer()).x0

fig, ax = plt.subplots(dpi=200)
ax.plot(range(10), label='Aardvark')
leg = ax.legend()
x02 = leg.get_window_extent(fig.canvas.get_renderer()).x0
assert pytest.approx(x01*2, 0.1) == x02