Fix rctemplate tests when user config file exists. #10929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`matplotlib_fname` returns the first of user config, environment variable-specified config, or default system config. If the user has a matplotlibrc, then this test checks that instead of the system one.
anntzer
reviewed
Mar 31, 2018
| @@ -447,7 +446,7 @@ def test_if_rctemplate_is_up_to_date(): | |||
| if k in line: | |||
| found = True | |||
| if not found: | |||
| missing.update({k:v}) | |||
| missing.update({k: v}) | |||
dstansby
approved these changes
Mar 31, 2018
matthew-brett
added a commit
to MacPython/matplotlib-wheels
that referenced
this pull request
Apr 8, 2018
Checking if matplotlib/matplotlib#10929 helps or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
matplotlib_fnamereturns the first of user config, environment variable-specified config, or default system config. If the user has a matplotlibrc, then this test checks that instead of the system one.Aiming for 2.2.3 because the test does not pass otherwise.
PR Checklist