FIX: Postscript allow empty markers #10935
Merged
+7
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstansby
approved these changes
Apr 1, 2018
jkseppan
approved these changes
Apr 1, 2018
|
Hmmm did we really want to backport this? I dont mind but I think we were only backportibg regressions and crashes. |
|
The documentation says "Everything else (regressions against 1.x versions, bugs/api inconsistencies the user can work around in their code) are on a case-by-case basis, should be low-risk, and need someone to advocate for and shepherd through the backport." I think this one is low-risk and I read @dstansby's comment as being willing to do the shepherding. |
dstansby
added a commit
that referenced
this pull request
Apr 1, 2018
Backport PR #10935 on branch v2.2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
If you set a marker to have
markerfacecolor='none'with the eps backend, no marker is drawn, even if the edgecolor is non-zero. Thats silly. This checks and if none, just doesn't issue the fill command instead of returning before anything is drawn...I couldn't figure out how to make a postscript test. The saved image is in pdf, but the test spits out an eps, so...
Closes #10921
PR Checklist