This would be the new output.

Could you add labels as in your original example and/or a legend, so that this looks more like a real-world usecase. Also, showing how to label your data is an important piece of information that should be conveyed in the example.

The nested donuts are already a more complex example. Maybe we should additionally add a simple donut plot, which could then include part of the labelling information.

There is the basic pie example and the pie demo2 both showing how to add labels. Are you sure this is needed?

The main point of this example was and is to show (a) nesting, (b) the two paths to get a pie (through pie and polar bars). I would not clutter it with additional labels or legends.

One thing we apparently do not have is an example of a pie chart with a legend. I could add that. Should that also show a donut then?

How hard would it be to put the nested pie charts into a function that users could copy-paste as a base for customized helper functions?

Specifically, functions that look like those described at https://matplotlib.org/tutorials/introductory/usage.html#coding-styles

Help! 🆘

I created the new example, which now looks like this.

because apparently the figure is created at the point where it ... (I don't know actually); but in any case I want it to be created at the bottom of the page of couse, when it got all its content.

How hard would it be to put the nested pie charts into a function that users could copy-paste as a base for customized helper functions?

Essentially the nested pie chart example can be copied into a function as it is. However I suppose the user needs to create one such function per given number of data points due to the colors being manually chosen from the colormap. Creating the logic to choose n colors with m shades of that color for a general purpose plotter goes a bit beyond the scope of this, doesn't it?
Also the example data format fixes two rings. Again, specifying a general purpose format for k rings with nesting is probably a bit too much here.

Or maybe I misunderstood the question, @tacaswell ?

As @phobson suggested,

I think this divider is why the plot isn't rendering fully

I removed the divider, but then the comments are real comments to the code, not text within the document. See result here. I would rather keep the text as text with links etc. than having it as commented code.

I now opened an issue about that at sphinx-gallery to see if anything can be done about it. If not, the example would probably need to be produced in two single figures.

Since the issue of creating the figure only at the end of the code cannot be solved currently as seen in sphinx gallery #363, I used two example figures. This is fine, except that the gallery thumbnail will only show the first of those.

Now, I tried squashing the 6 commits into one; now I ended up with 8 commits?? (Is there anything missing in rewriting-commit-history that would cause this?

But I think apart from me fighting with git, this is good to go now?

There is a Sphinx gallery command you can put in comments to set the thumbnail figure. I used it in the constrained layout tutorial if you’d like an example ( on phone so hard to look up directly).

EDIT: # sphinx_gallery_thumbnail_number = 18

To fix the git tangle suggest you move your modified file somewhere else, do

git reset --hard upstream/master

and then copy the file back, commit and push. This’ll leave you w one commit against master. Not such a good method if you have many changes but if just one file it works really well.

Ps I don’t usually merge commit. I do git rebase -i xxxxxxxx where xxxxxxx is the commit hash of the last commit I did not edit. That lets me squash all changes against that old commit.

This is crazy. There must be something like git merge all commits from branch <branchname> without me typing in random 9 digit numbers, getting spammed by editor windows popping up and constantly running into conflicts and out-of-sync stuff.

You shouldn't really have conflicts (no one else has edited this file). Strongly suggest you do what I origially suggested first and reset your branch to upstream/master and start over if you are getting conflicts: it sounds like giving up, but it really is the easiest way to recover from a mess up.

Of course you need not type in 9 digit numbers (though cutting and pasting from git log isn't that hard); you can also do git rebase -i HEAD~9 or however far back you need to go in history.

I do:

git checkout donut-doc
git fetch upstream
git rebase upstream/master
git rebase -i HEAD~8 # opens text editor, check your gitconfig
# use the fixup option on all but the first line
# save and exit text editor (for vim that's ":wq"
git push origin donut-doc --force

öahm... don't know if that was a good idea?! @phobson
If you look at the commits, I suddenly seem to have collaborators on this PR.

It’s because you did the merge. Just copy the files aside and reset hard and you’ll be fine.

I think I finally made it.

Concerning images it's not that one is better than the other; it's just it would have been nice to have them both as thumbnail. That would require to produce come static image, which is probably not desireable.

Great - Git can be a bit of a PITA if you hit a glitch in your workflow. Thanks for sticking with it.

I’ll merge once CI passes. These are great examples! Thanks...