-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Added share_tickers parameter to axes._AxesBase.twinx/y #10960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added copy constructor to axis.Ticker
Can you provide an example as well? I finally parsed why we would want this from the original issue, and I think it’d be a helpful example to have. I guess I’m also still concerned that @efiring issue with the locator being different is still valid because the locator also returns the autolims. Which locator wins if the locators are different? This should be consistent and documented. |
Given the warning of possible dire consequences, why do this at all? I think this is simply a bad idea, short of a total overhaul of the way we track and determine axis limits. |
I think it’s a useful idea to have a second scale for the same axis, which i think was the original idea. But I’m not at all sure this is the best way to do it. |
My personal example, is I have a timeseries data, on two shared x-axis. I want to put timestamps on one of the axis labels, but want to format the second axis labels a different way (but still have them linked, so when I drag or zoom one the other drags/zooms too). I don't think this is a bad idea at all in theory - the location of data on the graph is independent of the ticks and labels above. I'll have a proper look at the autoscaling worries soon. |
(at least as a minimum being able to set different formatters would be good if setting different locators is a problem.) |
To record my findings, the way I think
So I don't think having different locators is a problem code wise - there might just be different results depending on which axis is autoscaled, even if they are twinned. Would that be a problem? |
This and #10961 are almost the same thing.... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As with #1061, I don't think this is a good approach. I will try to come up with an alternative this weekend.
Okay, I'll close this in favour of discussion on #10976, thanks for taking the time to look over this! |
This is my attempt to resurrect #7528, which fixes #7376.