Skip to content

PGF: Replace \pgfimage by \includegraphics to fix \import regression #10973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

pwuertz
Copy link
Contributor

@pwuertz pwuertz commented Apr 6, 2018

The suggested method for importing PGF figures from other directories using the import package does not work anymore. Tex does not find the images referenced by the PGF file. Replacing \pgfimage by \includegraphics fixes this problem (fixes issue #10963).

@dstansby
Copy link
Member

dstansby commented Apr 6, 2018

xelatex doesn't seem to like this change in the travis build!

@pwuertz
Copy link
Contributor Author

pwuertz commented Apr 6, 2018

Ah yes, my current system uses TeX Live 2017, where \includegraphics accepts the interpolation parameter. The CI system is running TeX Live 2013, which apparently didn't support this, so \includegraphics really was not a viable option back in 2012. I knew there was a reason :D.

@pwuertz
Copy link
Contributor Author

pwuertz commented Apr 8, 2018

Attempt to upgrade TeX Live used by Travis to 2015 by adding PPA ppa:jonathonf/texlive-2015 failed. Honestly, I don't really understand the point of the jonathonf texlive PPAs. They claim backport different texlive versions to older LTS, but those PPAs hardly contain any texlive packages.

@dstansby
Copy link
Member

dstansby commented Apr 8, 2018

Well xelatex claims to be the 2015 version: https://travis-ci.org/matplotlib/matplotlib/jobs/363726207#L2738

@pwuertz
Copy link
Contributor Author

pwuertz commented Apr 8, 2018

I think that's a lie though. The PPA doesn't provide anything significant beyond texlive-base. In particular, it provides neither texlive-xetex nor texlive-luatex. So those must be still coming from 14.04 and just pick up the new version string from texlive base?

@jklymak jklymak added this to the v3.0 milestone May 9, 2018
@jklymak
Copy link
Member

jklymak commented May 9, 2018

Does this need to wait for more distros to have a more modern texlive? I'll mark needs upstream fix, though I know thats not quite the situation here...

@pwuertz
Copy link
Contributor Author

pwuertz commented May 10, 2018

In the real world I'd say the typically distributed TeX live version should be recent enough, it's just that Travis is stuck at the extremely old Ubuntu 14.04. Reading their comments on this they don't seem to consider upgrading to a newer version anytime soon and suggest using the Docker option of defining your own base image.

Is moving from Travis stock images to a Docker based setup something that is being considered for matplotlib?

@tacaswell tacaswell modified the milestones: v3.0, v3.1 Jul 15, 2018
@tacaswell
Copy link
Member

@pwuertz no, but in principle open to one or more of the builds in the test matrix moving over.

@jklymak jklymak modified the milestones: v3.1.0, v3.2.0 Feb 11, 2019
@jklymak
Copy link
Member

jklymak commented Feb 11, 2019

@pwuertz I bumped to 3.2, but if you think it'll work on modern CI, feel free to bumpy back...

@tacaswell tacaswell closed this Aug 28, 2019
@tacaswell tacaswell reopened this Aug 28, 2019
@tacaswell
Copy link
Member

power-cycled to re-trigger CI, looks like travis and azure are both too old...

@tacaswell
Copy link
Member

We probably should document #10963 (comment) ?

@anntzer
Copy link
Contributor

anntzer commented Sep 24, 2019

Superseded by #15150.

@anntzer anntzer closed this Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants