Simplify travis setup a bit. #11056
Merged
Simplify travis setup a bit. #11056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Splitting test_script.sh into its own file is a bit overkill (but then we can't use `set -x` as that applies to the whole script, using a subshell is a bit overkill). - pytest directly reads arguments from $PYTEST_ADDOPTS, use that. - We were setting $PYTHON_ARGS but not actually using it (that failed the legend docstring test), instead put a comment saying to set $PYTHONOPTIMIZE (which exists for that purpose). - ci/travis/setup.cfg can just as well be replaced by setting $MPLLOCALFREETYPE. - Yaml entries that are a single string don't need to get an extra indent. - matplotlibDeployKey.enc is unused since we switched to using circleci for doc builds. - ci/travis/silence was the only one left in its directory, so we may as well move it up once directory.
jklymak
reviewed
May 9, 2018
.travis.yml
Outdated
| fi | ||
| before_install: | | ||
| # test with non-ascii in path | ||
| mkdir /tmp/λ |
There was a problem hiding this comment.
I don't understand what this is doing, but why move this out of the if check?
There was a problem hiding this comment.
There used to be an error when a directory in the PATH contained non-ascii characters on Linux (something with subprocess/Py2), so to test the fix we just added such a directory to the PATH. This patch just makes the directory also present in the OSX test, because why not?
There was a problem hiding this comment.
Maybe the comment could be expanded why we are doing this test and what we do/do not if it fails.
This is code one will only see once in a while and it‘s good to be clear about what it does.
jklymak
approved these changes
May 9, 2018
dopplershift
approved these changes
May 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we can't use
set -xas that applies to the whole script, using asubshell is a bit overkill).
the legend docstring test), instead put a comment saying to set
$PYTHONOPTIMIZE (which exists for that purpose).
$MPLLOCALFREETYPE.
indent.
for doc builds.
well move it up once directory.
PR Summary
PR Checklist