Skip to content

Use GtkShortcutsWindow for Help tool. #11085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2018

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Apr 19, 2018

PR Summary

A followup to #11045, using GTK's builtin widgets for shortcuts, when they are available. I also applied a small hack of putting every shortcut in its own group, because then GTK automatically splits columns and pages.
screenshot from 2018-04-18 22-32-15

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@QuLogic QuLogic added this to the v3.0 milestone Apr 19, 2018
@jklymak
Copy link
Member

jklymak commented Apr 19, 2018

I guess its not this PR, but can the 1/2/3/4... be changed to 1-9 or something?

@QuLogic
Copy link
Member Author

QuLogic commented Apr 19, 2018

All the shortcuts are added to the widget and the / and other formatting is added by GTK automatically. If you wanted to coalesce like that, it'd be an enhancement for the GTK widget, I think.

@dstansby dstansby merged commit 41a81c0 into matplotlib:master Apr 22, 2018
@QuLogic QuLogic deleted the helptool-gtk3 branch April 22, 2018 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants