Changes to figure.clf() and suplot_adjust #11086
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d2289c9 to
54d5e19
Compare
jklymak
reviewed
Apr 19, 2018
lib/matplotlib/figure.py
Outdated
| Set *keep_observers* to True if, for example, | ||
| a gui widget is tracking the axes in the figure. | ||
| Parameters | ||
| --------- |
2a96fc9 to
1afff75
Compare
1afff75 to
541f151
Compare
anntzer
reviewed
May 11, 2018
| @@ -173,77 +173,81 @@ def __init__(self, left=None, bottom=None, right=None, top=None, | |||
| wspace=None, hspace=None): | |||
| """ | |||
| All dimensions are fractions of the figure width or height. | |||
| Defaults are given by :rc:`figure.subplot.[name]`. | |||
| Defaults are given by :rc:`figure.subplot.*`. | |||
There was a problem hiding this comment.
I don't really like any of them but I don't know a better one. I think that figure.subplot.[name] make it easier to understand what to write.
|
I think a simpler API would be to have |
6 tasks
|
A dict would be good but I don't think that that API are very good. |
541f151 to
de2f714
Compare
|
I made a small change so that the test passed again. |
|
@fredrik-1 sorry this fell off our radar - be sure to ping us if you pick it up again and you want it reviewed. |
6 tasks
|
I'm going to close as abandoned, but feel free to re-open if wanted. Thanks for the help @fredrik-1 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote some code to solve #11059
figure.clf()now sets the subplots parameters to their default values. This is a behavior that I have missed before and I think that it is the correct thing to do.rc_defaultis added to subplots_adjust to make it simpler to get back to default values when tuning the subplot parametersSubplotParamsobject has got a__repr__function with the important attributes such that it is easier to see and print what the subplot parameters areSubplotParamsobject has got a get function to make it easier to get its parametersSubplotParams.updatehas been written more compactI think that these changes make it easier to work with and understand the subplot parameters without changing the interface to much.
PR Checklist