Clean docstring of CountourSet #11090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstansby
commented
Apr 20, 2018
| @@ -757,44 +792,6 @@ class ContourSet(cm.ScalarMappable, ContourLabeler): | |||
| """ | |||
|
|
|||
| def __init__(self, ax, *args, **kwargs): | |||
| """ | |||
There was a problem hiding this comment.
numpydoc says to put the parameters section in the class docstring (not the __init__ docstring, before the attributes doc, which I think makes sense, and makes everything look a bit more sensible.
|
@dstansby, I'm 98% certain you gave a standing OK to push to your PRs. I just added links to |
|
@meeseeksdev backport to v2.2-doc |
|
Something went wrong ... Please have a look at my logs. |
|
@meeseeksdev backport to v2.2.2-doc |
tacaswell
pushed a commit
to tacaswell/matplotlib
that referenced
this pull request
Aug 5, 2018
Clean docstring of CountourSet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.