Skip to content

Pin sphinx to 1.7.2 to unbreak the doc build. #11107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2018
Merged

Pin sphinx to 1.7.2 to unbreak the doc build. #11107

merged 1 commit into from
Apr 23, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Apr 23, 2018 •
edited
Loading

PR Summary

Per https://gitter.im/matplotlib/matplotlib?at=5adcfa16109bb04332ec84ba.

Let's also try to unpin pyqt5 to see whether that issue is fixed.

Edit: yes, it is. Closes #10319.

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added the Build label Apr 23, 2018
@jenshnielsen
Copy link
Member

Builds are passing so lets merge to unbreak

@jenshnielsen jenshnielsen merged commit 0241d70 into matplotlib:master Apr 23, 2018
@anntzer anntzer deleted the pinsphinx branch April 23, 2018 06:37
@dstansby dstansby added this to the v2.2.3 milestone Apr 23, 2018
@dstansby
Copy link
Member

@meeseekesdev backport to v2.2.2-doc

@dstansby
Copy link
Member

@meeseeksdev backport to v2.2.2-doc

@lumberbot-app
Copy link

lumberbot-app bot commented Apr 23, 2018

There seem to be a conflict, please backport manually

dstansby pushed a commit to dstansby/matplotlib that referenced this pull request Apr 23, 2018
@jenshnielsen @dstansby
Merge pull request matplotlib#11107 from anntzer/pinsphinx
f8c120e 
Pin sphinx to 1.7.2 to unbreak the doc build.
@dstansby
Copy link
Member

@meeseeksdev backport to v2.2.x

@lumberbot-app
Copy link

lumberbot-app bot commented Apr 23, 2018

There seem to be a conflict, please backport manually

dstansby pushed a commit to dstansby/matplotlib that referenced this pull request Apr 23, 2018
@jenshnielsen @dstansby
Merge pull request matplotlib#11107 from anntzer/pinsphinx
1f429ae 
Pin sphinx to 1.7.2 to unbreak the doc build.
@anntzer anntzer mentioned this pull request Apr 24, 2018
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Build
Projects
None yet
Milestone
v2.2.3
Development

Successfully merging this pull request may close these issues.

TST: pyqt 5.10 breaks pyqt5 interactive tests
4 participants
@anntzer @jenshnielsen @dstansby @QuLogic