Skip to content

Make grid accept alpha rcParam #1114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 23, 2012
Merged

Make grid accept alpha rcParam #1114

merged 2 commits into from
Aug 23, 2012

Conversation

dmcdougall
Copy link
Member

This PR fixes #871

I should probably update the docstrings, too. And the default matplotlibrc file.

@dmcdougall
Copy link
Member Author

Actually, the docstrings for axes, etc don't need updated. They already accepted the alpha kwarg. I should update the default matplotlibrc file, though.

$ find . -iname '*rc'
./doc/matplotlibrc
./doc/pyplots/matplotlibrc
./lib/matplotlib/mpl-data/matplotlibrc
./lib/matplotlib/tests/test_rcparams.rc

Which one of these do I need to update?

@pelson
Copy link
Member

pelson commented Aug 21, 2012

Without any authority on the matter, I would say:

matplotlibrc.template
./lib/matplotlib/mpl-data/matplotlibrc
./doc/pyplots/matplotlibrc

While digging, I found lib/matplotlib/mpl-data/matplotlib.conf, can anyone tell me if this is still used?

Clearly this is highlighting an issue.

@pelson
Copy link
Member

pelson commented Aug 21, 2012

I've made an issue for discussion on the various rc files and the conf file to keep the conversations separate from this PR.

@dmcdougall
Copy link
Member Author

That's a great idea. Thanks.

I also found lib/matplotlib/mpl-data/matplotlib.conf.template too.

@dmcdougall
Copy link
Member Author

Wait a sec, I found this in the .gitignore file:

# Things specific to this project #
###################################
lib/matplotlib/mpl-data/matplotlib.conf
lib/matplotlib/mpl-data/matplotlibrc

Default grid.alpha is 1.0
@mdboom
Copy link
Member

mdboom commented Aug 21, 2012

matplotlibrc.template is the one to update.

@dmcdougall
Copy link
Member Author

Right, I will remove the update to the one under the docs directory. Thank you.

@pelson
Copy link
Member

pelson commented Aug 21, 2012

Looks fine to me. +1

mdboom added a commit that referenced this pull request Aug 23, 2012
Make grid accept alpha rcParam
@mdboom mdboom merged commit b0393e9 into matplotlib:master Aug 23, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grid.alpha in matplotlibrc
3 participants