Finish removing future imports. #11142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Apr 29, 2018
|
OK, removing these imports has complicated making code that can be backported to 2.2.3 and 3.0. What do folks do if they want a PR to be backported and merged into master? |
|
I think most things should backport cleanly, unless you're also modifying
the imports at the top of the import list? In which case a manual backport
doesn't seem too bad.
If that's too much of a pain we can revert this PR too, I don't mind at
all...
2018-04-30 10:46 GMT-07:00 Jody Klymak <notifications@github.com>:
… OK, removing these imports has complicated making code that can be
backported to 2.2.3 and 3.0. What do folks do if they want a PR to be
backported *and* merged into master?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#11142 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQv3uQ8jqkvHO_TBBvcsts_x0FfEqTNks5tt04DgaJpZM4TrrFD>
.
|
|
Seems that @ImportanceOfBeingEarnest is having conflicts on a couple of his PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
... nothing else than what the title says.
PR Checklist