Use explicit kwarg for plt.show() #11170
Conversation
lib/matplotlib/pyplot.py
Outdated
| """ | ||
| global _show | ||
| return _show(*args, **kw) | ||
| return _show(block=True) |
There was a problem hiding this comment.
I guess you mean return _show(block=block) here?
|
I do think it's a good idea. Maybe one could even check for |
|
Apparently there is a problem with the web backend which doesn't take any arguments. |
b8806d5 to
d4d80e5
Compare
| @@ -319,7 +319,10 @@ def trigger_manager_draw(manager): | |||
| manager.canvas.draw_idle() | |||
|
|
|||
| @staticmethod | |||
| def show(): | |||
| def show(block=True): | |||
There was a problem hiding this comment.
I thought we fixed this already....
|
I am 👎 on changing the default value. If the user passed I am very 👍 on @ImportanceOfBeingErnest 's suggestion of giving a good warning in the common incorrect use of passing figures or axes to |
|
Is there currently a difference between |
|
Concerning |
|
Going to close this since I can't remember what's going on. |
I feel like this might be a Bad Idea, but can't work out why - maybe others will be able to tell me if it is or not! Either way, the doc change is probably welcome.
Will add API notes if/when someone reviews.