Simplify lookup of animation external commands. #11229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... by using shutil.which instead of trying to run the command. Also, we don't need to explicitly call ImageMagickBase._init_from_registry because the writers.register decorator will do that for us (via the call to isAvailable).
dopplershift
approved these changes
May 11, 2018
tacaswell
reviewed
May 11, 2018
| @@ -772,8 +754,6 @@ def isAvailable(cls): | |||
| cls._init_from_registry() | |||
| return super().isAvailable() | |||
|
|
|||
| ImageMagickBase._init_from_registry() | |||
There was a problem hiding this comment.
why don't we need this any more?
There was a problem hiding this comment.
🐑 read the whole PR top matter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... by using shutil.which instead of trying to run the command.
Also, we don't need to explicitly call
ImageMagickBase._init_from_registry because the writers.register
decorator will do that for us (via the call to isAvailable).
PR Summary
PR Checklist