Skip to content

Re-run boilerplate.py. #11251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2018
Merged

Re-run boilerplate.py. #11251

merged 1 commit into from
May 15, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented May 15, 2018

Also remove second blank line between cmap definitions, consistently
with the other wrapper functions.

xref #11234 (comment)

Planning to selfmerge as "unbreaking the build".

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Re-run boilerplate.py.
107431e 
Also remove second blank line between cmap definitions, consistently
with the other wrapper functions.
@anntzer anntzer added the Build label May 15, 2018
@QuLogic QuLogic merged commit 126113f into matplotlib:master May 15, 2018
@QuLogic QuLogic added this to the v3.0 milestone May 15, 2018
@QuLogic
Copy link
Member

QuLogic commented May 15, 2018

Merging to fix build issues.

@anntzer anntzer deleted the fix-pyplot branch May 15, 2018 05:12
@timhoffm
Copy link
Member

Just a remark:

Also remove second blank line between cmap definitions, consistently
with the other wrapper functions.

Technically, PEP-8 wants two blank lines between top-level functions. Not sure why it does not complain. Maybe we have deactivated that check, or the comment counts as blank line. Didn't check.

@anntzer
Copy link
Contributor Author

anntzer commented May 15, 2018

  1. It's probably disabled for that specific file
  2. PEP8 also says "Extra blank lines may be used (sparingly) to separate groups of related functions. Blank lines may be omitted between a bunch of related one-liners (e.g. a set of dummy implementations)." Yes, these are strictly speaking not one-liners, but I think it's close in spirit (and think 2 blank lines are totally pointless here).

@tacaswell
Copy link
Member

Thank you @anntzer !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
Build
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @QuLogic @timhoffm @tacaswell